-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmov: XOR within the ASM block #925
Conversation
Looks like a legit test failure? |
The test failure seems legitimate? |
I'm not too sure. It's only happening for Maybe my testing methodology is flawed, I'll try changing some things up there too. Everything (in theory) should be working just fine. |
I tested locally on my R9 7950X, forcing it to use the I even temporarily removed |
Further oddness -
This was performed by forcing the x86 backend (by commenting the others out completely). AFAICT the code works just fine? Very odd. |
Would it be possible for anyone else to give this a shot on Quick command: |
…ial garbage in the register
I fixed the issue thanks to a very helpful person in the Rust Discord server. It turns out that This meant that the XOR was always inconsistent as we only wanted to compare the lower half of the register, so by using We can still use I am very grateful for the Rust Discord server, and this has helped me learn a lot - and helped this pull request become merge-ready. |
cc @tarcieri |
Now that #924 is a thing, we should be able to viably use
XOR
within the ASM block as opposed to within Rust.This closes #920.