Added definitions for ImageButton with explicit ID

[Sinan-Karakaya]

Hello!

I've added support for the new definitions of ImGui::ImageButton that support explicitely setting the id of the widget.
This feature was added in ImGui v1.89 and wasn't implemented in ImGui-SFML as far as I was aware.

Please give any feedback if something is wrong. Thanks :)

[ChrisThrasher]

This will require we raise the minimum ImGui requirement from 1.87 to 1.89. @eliasdaler Thoughts on raising that requirement?

[Sinan-Karakaya]

This will require we raise the minimum ImGui requirement from 1.87 to 1.89. @eliasdaler Thoughts on raising that requirement?

For what's it's worth, it seems like the old definitions are still available in 1.89, although they are now marked as deprecated.

[ChrisThrasher]

Search the repo for "1.87". You should find another reference to that version in a build script.

[ChrisThrasher]

Are there certain package managers still shipping <1.89 that we would break support with if we raised this requirement?

[Sinan-Karakaya]

Search the repo for "1.87". You should find another reference to that version in a build script.

Found it and fixed it in CMakeLists.txt

Are there certain package managers still shipping <1.89 that we would break support with if we raised this requirement?

I would have to check, I mostly use FetchContent with ImGui-SFML so I'm not sure about that

[ChrisThrasher]

Search the repo for "1.87". You should find another reference to that version in a build script.

Search again. There are more references to 1.87.

[Sinan-Karakaya]

Search the repo for "1.87". You should find another reference to that version in a build script.

Search again. There are more references to 1.87.

You're right my bad, should be fine now (🤞)

[ChrisThrasher]

Thanks for cleaning that up.

I'm going to give Elias time to weigh in one whether he likes increasing this minimum requirement.

[eliasdaler]

I'm going to give Elias time to weigh in one whether he likes increasing this minimum requirement.

Let's do it. 1.89 was released more than a year ago and Dear ImGui is a fast moving library which many users are expected to keep up with since it rarely breaks its API.

[eliasdaler]

Shouldn't overloads without const char* id be removed? It seems like you can't call ImGui::ImageButton without passing a label/id since 1.89.

[Sinan-Karakaya]

Shouldn't overloads without const char* id be removed? It seems like you can't call ImGui::ImageButton without passing a label/id since 1.89.

They can be kept, as those definitions are still available in 1.89. The only difference is that they are now marked as deprecated.

[eliasdaler]

Shouldn't overloads without const char* id be removed? It seems like you can't call ImGui::ImageButton without passing a label/id since 1.89.

They can be kept, as those definitions are still available in 1.89. The only difference is that they are now marked as deprecated.

I see. Let's just drop these overloads - it's better than copy-paste and we'll need to get rid of them eventually.

[Sinan-Karakaya]

Shouldn't overloads without const char* id be removed? It seems like you can't call ImGui::ImageButton without passing a label/id since 1.89.

They can be kept, as those definitions are still available in 1.89. The only difference is that they are now marked as deprecated.

I see. Let's just drop these overloads - it's better than copy-paste and we'll need to get rid of them eventually.

Just dropped them in last commit

[eliasdaler]

Much better.
@ChrisThrasher, please look at it again and feel free to merge.