Uninett/jinja2 filters #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #167 +/- ##
===========================================
+ Coverage 58.33% 58.37% +0.04%
===========================================
Files 59 60 +1
Lines 5942 5980 +38
===========================================
+ Hits 3466 3491 +25
- Misses 2476 2489 +13
Continue to review full report at Codecov.
|
katsel
force-pushed
the
uninett/jinja2-filters
branch
from
58bbb24
to
aefe3b7
Compare
katsel
force-pushed
the
uninett/jinja2-filters
branch
from
c4fcf45
to
c582e0f
Compare
|
Almost ready for merge now. Still to do
|
|
|
katsel
force-pushed
the
uninett/jinja2-filters
branch
2 times, most recently
from
58989d7
to
5c6dced
Compare
- Import filters into the jinja environment via nornir_helper - Add jinja filter to increment an IP address/interface - Add unit tests for IP incrementation, covering IPv4 and IPv6
- it messes with the jinja filter unit tests - "probably not needed any longer"
Co-authored-by: Svein Ove Undal <sveinov@uninett.no>
katsel
force-pushed
the
uninett/jinja2-filters
branch
from
5c6dced
to
e2aa35d
Compare
Branch is ready for merge now from our side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfinished draft/WIP PR for review purposes.
ToDo:
Jinja2 filter functions
Unit tests for functions
invoke filter functions
Any part that touches jinja2 templates should be made aware of the filter functions, e.g.
insync_devices.pynornir_helper.pytemplate_dry_run.py