Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select]: deprecation warning fired about using Textbox in an uncontrolled way #6883

Open
1 task done
edleeks87 opened this issue Aug 7, 2024 · 1 comment · May be fixed by #6996
Open
1 task done

[Select]: deprecation warning fired about using Textbox in an uncontrolled way #6883

edleeks87 opened this issue Aug 7, 2024 · 1 comment · May be fixed by #6996
Labels
Bug On Backlog

Comments

@edleeks87
Copy link
Contributor

Description

We are using Textbox in an uncontrolled way in the Select components which is causing a deprecation warning to be logged in the console even when the component has an onChange and value passed

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-7feesv

Steps to reproduce

Load repro and inspect console for deprecation warning

JIRA ticket numbers (Sage only)

No response

Suggested solution

Use the composed Textbox in a controlled way or add a mechanism to disable the warning when in Select

Carbon version

latest

Design tokens version

4.32.0

Relevant browsers

Firefox, Chrome, Safari, Microsoft Edge

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@edleeks87 edleeks87 added Bug triage Triage Required labels Aug 7, 2024
@Parsium
Copy link
Contributor

Parsium commented Aug 13, 2024

FE-6759

@Parsium Parsium added On Backlog and removed triage Triage Required labels Aug 13, 2024
edleeks87 added a commit that referenced this issue Oct 3, 2024
@edleeks87
fix(select): prevent deprecation warning about uncontrolled textbox f…
2028223 
…rom being fired

Ensures that Textbox used in Select components is used in a controlled manner to prevent the
deprecation warnings from being fired

fix #6883
@edleeks87 edleeks87 linked a pull request Oct 3, 2024 that will close this issue
Draft
7 tasks
edleeks87 added a commit that referenced this issue Oct 3, 2024
@edleeks87
fix(select): prevent deprecation warning about uncontrolled textbox f…
6de179c 
…rom being fired

Ensures that Textbox used in Select components is used in a controlled manner to prevent the
deprecation warnings from being fired

fix #6883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): prevent deprecation warning about uncontrolled textbox from being fired Sage/carbon
2 participants
@Parsium @edleeks87