Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabaseConnection directly from PgPool #2348

Merged

Conversation

fosskers
Copy link
Contributor

@fosskers fosskers commented Sep 3, 2024

PR Info

This allows sqlx-based connection pools that were already on-hand to be easily converted into SeaORM types.

New Features

Two new From impls which allow a native PgPool to be easily converted into SeaORM wrapper types that can then be used for SeaORM logic.

This allows sqlx-based connection pools that were already on-hand to be
easily converted into SeaORM types.
@fosskers fosskers changed the title feat(postgres): create DatabaseConnection directly from PgPool DatabaseConnection directly from PgPool Sep 3, 2024
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fosskers, good idea! I also implemented for MySqlPool and SqlitePool

@billy1624 billy1624 merged commit 8339dbb into SeaQL:master Oct 4, 2024
25 checks passed
Copy link

github-actions bot commented Oct 4, 2024

🎉 Released In 1.1.0-rc.2 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants