feat: implement PartialEq for SimpleExpr and its related types

[billy1624]

PR Info

• Dependents:
  • Add default_expr support for ColumnDef sea-orm#1474

New Features

• Implemented PartialEq for SimpleExpr and on its related types

Breaking Changes

• Remaned SeaRc into RcOrArc
• Added a new struct SeaRc which resemble the API of SeaRC as it used to be

let table_as: DynIden = SeaRc::new(Alias::new("char"));
// Or,
let table_as: DynIden = Alias::new("char").into_iden();

// Clone it
let cloned: DynIden = SeaRc::clone(&table_as);

// From a enum Iden
let char_id: DynIden = Character::Id.into_iden();

[tyt2y3]

Thank you for the effort.
I agree we have to own the type DynIden in order to make this work.
However, I suspect we may be able to make an upgrade via the type SeaRc.

pub type DynIden = SeaRc<Iden>;

#[drive(Clone, ... many)]
#[repr(transparent)]
pub struct SeaRc<I>(i: RcOrArc<dyn I>);

// we only implement it for Iden
impl<I: Iden> SeaRc<I> {
    pub fn new(i: I) -> DynIden {
        Self(RcOrArc::new(i))
    }
}

That way we don't have to maintain two types! Although it is a breaking change, I hope that the typical user would not need to change a lot of things, if they are already using SeaRc.

[billy1624]

It works! But with a bit more extra efforts :P

Let me think about it and revisit this tmr morning

[ikrivosheev]

@billy1624 thank you! I have one question.

[tyt2y3]

Phenomenal!

[github-actions]

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

[github-actions]

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.