mysql create table add table and colunm comment #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/table/column.rs # src/table/create.rs
ikrivosheev
reviewed
Mar 21, 2023
Co-authored-by: Ivan Krivosheev <py.krivosheev@gmail.com>
4 tasks
use by sea-orm codegen
ikrivosheev
requested changes
Mar 24, 2023
ikrivosheev
approved these changes
Mar 27, 2023
|
@billy1624 do you want to include it into 0.29 release?) |
tyt2y3
reviewed
Apr 3, 2023
tyt2y3
reviewed
Apr 3, 2023
tyt2y3
reviewed
Apr 3, 2023
tyt2y3
reviewed
Apr 3, 2023
tyt2y3
reviewed
Apr 3, 2023
src/backend/mysql/table.rs
Outdated
Comment on lines
206
to
207
| let comment = comment.replace('\'', "\\'"); | ||
| write!(sql, "COMMENT '{comment}'").unwrap() |
There was a problem hiding this comment.
We have a standard way to escape string
tyt2y3
reviewed
Apr 3, 2023
tyt2y3
requested changes
Apr 3, 2023
tyt2y3
approved these changes
Apr 4, 2023
tyt2y3
reviewed
Apr 4, 2023
| /// r#"`character` varchar(255) NOT NULL,"#, | ||
| /// r#"`size_w` int NOT NULL,"#, | ||
| /// r#"`size_h` int NOT NULL,"#, | ||
| /// r#"`font_id` int DEFAULT NULL,"#, | ||
| /// r#"CONSTRAINT `FK_2e303c3a712662f1fc2a4d0aad6`"#, | ||
| /// r#"FOREIGN KEY (`font_id`) REFERENCES `font` (`id`)"#, | ||
| /// r#"ON DELETE CASCADE ON UPDATE CASCADE"#, | ||
| /// r#") COMMENT 'table comment'"#, | ||
| /// r#") COMMENT 'table\'s comment'"#, |
|
sea-orm 0.11.2 still not working with comment ,is this feature published now ? |
|
No, it's been merged, but not yet released. |
🎉 Released In 0.29.1 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
mysql create table add table and colunm comment
Changes