Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally add filter types list with features #67

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Oct 1, 2022

Adds

  • Uuid support for Filter derive macro

Fixes

  • Filter no longer includes types in the default filters list when the matching feature flags are not enabled

Breaking Changes

  • In theory, it would break some UI tests... But I don't think it's worth considering those cases

Changes

  • seaography-derive now includes 3 new features: with-chrono, with-decimal, with-uuid. Those match the features from the parent crate.

@karatakis
Copy link
Collaborator

Looks good to me.
@billy1624 @tyt2y3 whats your opinion ?

@tyt2y3
Copy link
Member

tyt2y3 commented Oct 5, 2022

Oh oh oh is here our first external contributor?

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome

@tyt2y3 tyt2y3 merged commit a4209f8 into SeaQL:main Oct 5, 2022
@XiNiHa XiNiHa deleted the derive-features branch October 5, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants