Skip to content

Commit

Permalink
fix(module): set import.meta.url as parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
jlenon7 committed Jul 6, 2022
1 parent 0ba90e1 commit 4c4df95
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 11 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@secjs/utils",
"version": "1.9.5",
"version": "1.9.6",
"description": "Utils functions and classes for Node.js",
"license": "MIT",
"author": "João Lenon <lenon@athenna.io>",
Expand Down
14 changes: 8 additions & 6 deletions src/Helpers/Module.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,12 @@ export class Module {
/**
* Create the __dirname property. Set in global if necessary.
*
* @param {boolean} setInGlobal
* @param {string} [url]
* @param {boolean} [setInGlobal]
* @return {string}
*/
static createDirname(setInGlobal = false) {
const __dirname = dirname(Module.createFilename(false))
static createDirname(url = import.meta.url, setInGlobal = false) {
const __dirname = dirname(Module.createFilename(url, false))

if (setInGlobal) {
global.__dirname = __dirname
Expand All @@ -173,11 +174,12 @@ export class Module {
/**
* Create the __filename property. Set in global if necessary.
*
* @param {boolean} setInGlobal
* @param {string} [url]
* @param {boolean} [setInGlobal]
* @return {string}
*/
static createFilename(setInGlobal = false) {
const __filename = fileURLToPath(import.meta.url)
static createFilename(url = import.meta.url, setInGlobal = false) {
const __filename = fileURLToPath(url)

if (setInGlobal) {
global.__filename = __filename
Expand Down
4 changes: 2 additions & 2 deletions src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -435,9 +435,9 @@ export class Module {

static import(path: string): Promise<any>

static createDirname(setInGlobal?: boolean): string
static createDirname(url?: string, setInGlobal?: boolean): string

static createFilename(setInGlobal?: boolean): string
static createFilename(url?: string, setInGlobal?: boolean): string
}


Expand Down

0 comments on commit 4c4df95

Please sign in to comment.