Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add move and copy methods to File and Folder classes #31

Merged
merged 2 commits into from
Nov 26, 2021
Merged

feat: Add move and copy methods to File and Folder classes #31

merged 2 commits into from
Nov 26, 2021

Conversation

jlenon7
Copy link
Contributor

@jlenon7 jlenon7 commented Nov 26, 2021 •
edited
Loading

Proposed changes

Resolve #28 #30

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@jlenon7 jlenon7 added documentation Improvements or additions to documentation feature New feature or request fix Fix something that is not working test Adding missing tests or correcting existing tests labels Nov 26, 2021
@jlenon7 jlenon7 requested a review from txsoura November 26, 2021 02:07
@jlenon7 jlenon7 self-assigned this Nov 26, 2021
@jlenon7 jlenon7 linked an issue Nov 26, 2021 that may be closed by this pull request
Improve the File and Folder JSDoc and README to show the default config values ​​in the methods #30
Closed
@jlenon7
Copy link
Contributor Author

jlenon7 commented Nov 26, 2021

Before merge, it is necessary to improve the JSDoc of the File and Folder class.

@jlenon7 jlenon7 merged commit a5e16bd into main Nov 26, 2021
@jlenon7 jlenon7 deleted the feat/len-add-move-copy branch November 26, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@txsoura txsoura Awaiting requested review from txsoura

Assignees

@jlenon7 jlenon7

Labels
documentation Improvements or additions to documentation feature New feature or request fix Fix something that is not working test Adding missing tests or correcting existing tests
Projects
None yet
Milestone
No milestone
1 participant
@jlenon7