Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement String and Is class and new methods to Parser #40

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

jlenon7
Copy link
Contributor

@jlenon7 jlenon7 commented Feb 7, 2022

Proposed changes

Add String and Is class, new methods to Parser and move some functions to classes

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@jlenon7 jlenon7 added feature New feature or request refactor Refactor a past feature fix Fix something that is not working test Adding missing tests or correcting existing tests labels Feb 7, 2022
@jlenon7 jlenon7 requested a review from txsoura February 7, 2022 18:36
@jlenon7 jlenon7 self-assigned this Feb 7, 2022
@jlenon7 jlenon7 merged commit 49ed2db into main Feb 7, 2022
@jlenon7 jlenon7 deleted the feat/len-string-and-is branch February 7, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request fix Fix something that is not working refactor Refactor a past feature test Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant