Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transition] gets destroyed by new transition call in onComplete #2583

Closed
hpohl opened this issue Jul 10, 2015 · 5 comments
Closed

[Transition] gets destroyed by new transition call in onComplete #2583

hpohl opened this issue Jul 10, 2015 · 5 comments
Labels
Confirmed Bug
Milestone
2.0.4

Comments

@hpohl
Copy link

hpohl commented Jul 10, 2015

https://jsfiddle.net/zeneL1ha/3/

Calling .transition in onComplete causes the transition to not show at all but still change the visible state.
@jlukic
Copy link
Member

jlukic commented Jul 10, 2015

This is happening for me only in FF and not chrome. I'll see if I can find a fix.

@hpohl
Copy link
Author

hpohl commented Jul 10, 2015

It's also happening in Chrome 45.

@jlukic jlukic added this to the 2.0.4 milestone Jul 13, 2015
@jlukic
Copy link
Member

jlukic commented Jul 13, 2015

I'm testing in Chrome 43 and seems alright, but a few behind. I've marked this for next patch.

jlukic added a commit that referenced this issue Jul 17, 2015
@jlukic
#2583 Fixes onComplete is not called at true 'end of animation'
bb9bbad
@jlukic
Copy link
Member

jlukic commented Jul 17, 2015

@hpohl This regression was introduce in #2402, complete was not occurring at true "end of animation". force visible / force hidden is now called before onComplete

Should be fixed in next patch

jlukic added a commit that referenced this issue Jul 17, 2015
@jlukic
#2583 onHide/onShow should be last as well
cba22a8
jlukic added a commit that referenced this issue Jul 17, 2015
@jlukic
#2583 rlsnotes
95542ce
@jlukic jlukic closed this as completed Jul 17, 2015
@hpohl
Copy link
Author

hpohl commented Jul 19, 2015

Nice 👍

jlukic added a commit that referenced this issue Aug 17, 2015
@jlukic
Fixes #2583 issue with menu disappearing using allowAdditions: true
015a6fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.0.4
Development

No branches or pull requests
2 participants
@jlukic @hpohl