Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

".ui.form .divider" rule breaks ".ui.vertical.divider" #3092

Closed
Parakleta opened this issue Sep 25, 2015 · 5 comments
Closed

".ui.form .divider" rule breaks ".ui.vertical.divider" #3092

Parakleta opened this issue Sep 25, 2015 · 5 comments

Comments

@Parakleta
Copy link

As the subject line says. There is a rule in form.css that adds a margin to all .divider inside .ui.form which messes up .ui.vertical divider alignment. Consider using :not(.ui) or :not(.vertical) in the form.css rule.

@jlukic
Copy link
Member

jlukic commented Sep 25, 2015

Please create a test case so I can evaluate the bug. There is a jsfiddle to fork in the readme

@Parakleta
Copy link
Author

Here's the fiddle.

Edit: excuse my self-closing tags, too much time spent writing JSX.

@jlukic jlukic added this to the 2.1.5 milestone Sep 29, 2015
@jlukic
Copy link
Member

jlukic commented Sep 29, 2015

Thanks, this is clearly a bug

@treble-snake
Copy link

Btw, it's not only about "vertical" rule. E.g. "fitted" rule is also broken.
http://jsfiddle.net/q39snkqw/1/
Guess there is more there.

jlukic added a commit that referenced this issue Nov 1, 2015
jlukic added a commit that referenced this issue Nov 1, 2015
@jlukic jlukic modified the milestones: 2.1.5, 2.1.7 Nov 6, 2015
@jlukic
Copy link
Member

jlukic commented Dec 19, 2015

Should be solved in 2.1.6 (see commits) this was accidentally mistagged.

@jlukic jlukic closed this as completed Dec 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants