Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] onRate() for .ui.ratings is always called #3712

Closed
cwbit opened this issue Feb 18, 2016 · 1 comment
Closed

[bug] onRate() for .ui.ratings is always called #3712

cwbit opened this issue Feb 18, 2016 · 1 comment
Milestone

Comments

@cwbit
Copy link

cwbit commented Feb 18, 2016

There is a bug with .ui.ratings where the onRate() for .ui.ratings is always called (i.e. on page load) even before the user has interacted with it. This means all on-page ratings can fire API calls even if the user has not actually interacted with it yet.

Here is an example.

@jlukic I'm also including your response to this from Gitter just in case

@cwbit It does seem the case, looks like rating needs a fireOnInit setting like checkbox
https://github.com/qualialabs/qualia/blob/dev/app/client/lib/semantic_ui/definitions/modules/checkbox.js#L773
Probably should default to false
@cwbit this seems very clearly to be a bug, derp

@cwbit cwbit changed the title [bug] onRate() for .ui.ratings is *always* called [bug] onRate() for .ui.ratings is always called Feb 18, 2016
@jlukic jlukic added this to the 2.1.9 milestone Feb 18, 2016
@jlukic
Copy link
Member

jlukic commented Feb 18, 2016

Thanks for filing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants