-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an option to sign using SAD in addition to OTP #3
Added an option to sign using SAD in addition to OTP #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, it really makes sense. Just some cosmetic changes for now.
Minor code styling fixes
Thank you for this PR. I fixed the minor styling issues for you. Also I removed the setSigningMethod() and simply decide internaly by checking the given properties which signing method is to use. @Binternet What do you think about this change? |
@MaximilianKresse great change and does the job much better, thanks for this! |
No description provided.