Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add mock for animated flashlist #826

Merged

Conversation

iamshadmirza
Copy link
Contributor

Description

Fixes (issue #825)

Mocks are added for FlashList only, this results in failing tests for AnimatedFlashList usage.
I'm importing AnimatedFlashList as follows.

import { AnimatedFlashList } from '@shopify/flash-list';

This PR adds mocks for AnimatedFlashList, which is same as FlashList

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)

Checklist

@iamshadmirza
Copy link
Contributor Author

I have signed the CLA!

@iamshadmirza
Copy link
Contributor Author

Hey @naqvitalha
What's the process of getting my PR reviewed?
Would be huge help if you can you help me understand.

@naqvitalha
Copy link
Collaborator

Hey @iamshadmirza, we really appreciate the PR. We'll get to it very soon. Apologies for the delay, we've been a little caught up in some parallel tracks.

@iamshadmirza
Copy link
Contributor Author

Hey @iamshadmirza, we really appreciate the PR. We'll get to it very soon. Apologies for the delay, we've been a little caught up in some parallel tracks.

Hey 👋
No worries. Just wanted to confirm if I'm doing it right.

@naqvitalha naqvitalha merged commit f91bcb1 into Shopify:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants