Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent expired flag from resetting #915

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Prevent expired flag from resetting #915

merged 3 commits into from
Sep 14, 2023

Conversation

naqvitalha
Copy link
Collaborator

@naqvitalha naqvitalha commented Sep 14, 2023 •
edited
Loading

Description

expired flag in layout provider was getting reset in the updateProps method. This PR addresses the issue

Reviewers’ hat-rack 🎩

N/A

Screenshots or videos (if needed)

Checklist

sbirksted
sbirksted approved these changes Sep 14, 2023
View reviewed changes
Copy link

@sbirksted sbirksted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naqvitalha naqvitalha merged commit c606f62 into main Sep 14, 2023
13 checks passed
@naqvitalha naqvitalha deleted the fix-expiry-condition branch September 14, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbirksted sbirksted sbirksted approved these changes

@davebcn87 davebcn87 Awaiting requested review from davebcn87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naqvitalha @sbirksted