Support AR Enumerators for models with composite primary keys using :id #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use `#id_value` instead of `#id` for models with composite primary keys when accessing the record value, because `#id` gives us back the primary key value when we want the `:id` column value. Co-authored-by: Nikita Vasilevsky <nikita.vasilevsky@shopify.com>
adrianna-chang-shopify
force-pushed
the
ac-fix-cpk-enumerators
branch
from
ac3d9dd
to
9518cc9
Compare
|
Thanks for fixing this! Could you add it to the change log as unreleased? |
|
Yes, thanks for the nudge @Mangara ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use
#id_valueinstead of#idfor models with composite primary keys when accessing the record value, because#idgives us back the primary key value when we want the:idcolumn value.