Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional sorbet-runtime support for JobIteration::Iteration interface validation #47

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Optional sorbet-runtime support for JobIteration::Iteration interface validation #47

merged 2 commits into from
Feb 25, 2020

Commits on Feb 25, 2020

  1. Optional sorbet-runtime support for interface validation 

    Methods that have Sorbet signatures are wrapped by `sorbet-runtime` so
that they can be type-checked for correct params/return-value at
runtime. However, that wrapper does not and cannot relay the whole
information about the original method like `arity` or `parameters`.
(Ref: sorbet/sorbet#2643)

The workaround is to access the original method from the signature
if we detect Sorbet is activated and the method in question has a
signature.

This commit abstracts the method parameter extraction into a separate
method in order to carry out that workaround.
    @paracycle
    paracycle committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    82170ff View commit details
    Browse the repository at this point in the history

  2. Add test case for sorbet-runtime support

    @paracycle
    paracycle committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    e923331 View commit details
    Browse the repository at this point in the history