Fix memory leak in active record cursor #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmortonShopify
approved these changes
Mar 24, 2021
pedropb
force-pushed
the
fix-memory-leak-in-AR-cursor-next-batch
branch
from
218309e
to
84218c4
Compare
This commit patches the active record cursor implementation so that the queries emitted by `relation.to_a` in `next_batch` are never cached. This makes sense because it is a waste to cache results of queries like `SELECT ... WHERE id > ... LIMIT ...` in an enumerator that is only moving forward. The `uncached` interface I make use of in this commit was introduced by rails/rails#28867 under a similar context.
GustavoCaso
force-pushed
the
fix-memory-leak-in-AR-cursor-next-batch
branch
from
84218c4
to
342df24
Compare
etiennebarrie
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit patches the active record cursor implementation so that the
queries emitted by
relation.to_ainnext_batchare never cached.This makes sense because it is a waste to cache results of queries like
SELECT ... WHERE id > ... LIMIT ...in an enumerator that is onlymoving forward.
The
uncachedinterface I make use of in this commit was introduced byrails/rails#28867 under a similar context.