This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Update link in README to CLI install docs #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
reviewed
Dec 13, 2022
There was a problem hiding this comment.
Oops.. I've missed a minor detail :)
I believe we may also update the URL in the line 30 as well (to https://shopify.dev/themes/tools/cli).
Poitrin
force-pushed
the
update-link-in-readme-to-cli-docs
branch
from
37b428b
to
fe28b93
Compare
Great catch 🚀 , I changed it :) |
charlespwd
approved these changes
Dec 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When extension users go through Installation steps (either via Marketplace or via page in VS Code), they will click on https://shopify.dev/tools/cli/installation
This link however redirects to the CLI’s Apps section.
Solution
Update the aforementioned link to https://shopify.dev/themes/tools/cli/install, so that users install the app globally (for theme development), and also see the system requirements.