refactor: Declare exports in package.json #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonAlling
added a commit
that referenced
this pull request
Jul 18, 2024
This release makes imports from `bootstrap/` and/or `build/internal/` (which have never been intended to work) TypeScript compilation errors (#105).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the public API explicit using
exportsandtypesVersionsinpackage.json. This should enable us to reorganize internal modules, compile to adistdirectory etc without having to release (or consider releasing) a new major version.I haven't been able to figure out any way to make TypeScript find the index module (when our consumer does
import … from "userscripter"), except keeping themainfield as is.This is a backward compatible change as long as our consumer doesn't import anything from
bootstrap/orbuild/internal/. That has never been intended to work, and it seems unlikely to me that anyone will have done that and expected it to be stable.