Fix for #158 and #121 #159
Conversation
…" This fixes $158. This reverts commit b00938e.
|
Have you checked that this change does not re-introduce the issue(s) that were originally fixed by the commit in question? |
|
Ill check that now, still a similar fix has to be done in 1.21 aswell. |
|
So if there is a real fix for 1.21. i would just like to see if backported. Dont want to put too much on your plate tho, hopefully identifying the commit helps |
|
Fabric seemenly fixed the bug in FabricMC/fabric#3517. So maybe reverting our fix won't do much. still testing |
|
The original jukebox bug gets unpatched, i can confirm that, but is this tiny bug really worth losing support for all transport pipes? including piping out of jukeboxes Not to mention this bug exists in 1.21 |
|
The solution here is to merge this commit which fixes the bug in 1.20 and 1.21 and implement Fabric upstream's fix for the jukebox mixin in the transfer api. I don't mind doing it if your not up for the task. If so do you want two serprate PRs or the same PR |
Fixes #158 and should fix #121
This reverts commit b00938e.
If this somehow doesn't get merged i have no choice but to fork the mod, which i believe is allowed under the license. Mind confirming that?