Skip to content

Commit

Permalink
Merge pull request #188 from Snapchat/lf/revert-objc-future-nonnull
Browse files Browse the repository at this point in the history
Revert "Make DJFuture results nonnull in objective C"
  • Loading branch information
bholmes-sc authored Sep 3, 2024
2 parents 971228b + 00986fc commit 4dafc5b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions support-lib/objc/DJFuture.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
// If the future is ready, then calling its `get` method will not block.
- (BOOL) isReady;
// Block and wait for the result (or exception). This can only be called once.
- (nonnull DJValue) get;
- (nullable DJValue) get;
// Tell the future to Call the specified handler routine when it becomes
// ready. Returns a new future that wraps the return value of the handler
// routine. The current future becomes invalid after this call.
Expand All @@ -40,7 +40,7 @@
- (nonnull DJFuture<DJValue> *)getFuture;
// `setValue` or `setException` can only be called once on a promise. After
// which the internal state becomes invalid.
- (void)setValue:(nonnull DJValue)val;
- (void)setValue:(nullable DJValue)val;
// for NSNull* (void)
- (void)setValue;
- (void)setException:(nonnull NSException *)exception;
Expand Down

0 comments on commit 4dafc5b

Please sign in to comment.