Composer generator #160
Merged
Composer generator #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bholmes-sc
approved these changes
Feb 22, 2024
|
|
||
| #pragma once | ||
|
|
||
| #include "djinni_composer.hpp" |
There was a problem hiding this comment.
is order important here? if not sort them.
| #pragma once | ||
|
|
||
| #include "djinni_composer.hpp" | ||
| #include "../cpp/expected.hpp" |
There was a problem hiding this comment.
can we avoid the relative paths?
There was a problem hiding this comment.
removed relative paths. they are not needed. "cpp" is already in include search path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code generator for bridging C++ and Composer/TypsScript.
The TypeScript type definitions reuses the TS generator for WebAssembly because they are 99% the same.
The C++ marshalling code targets the new Composer support library.