Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AprilTag support to Limelight #70

Merged
merged 6 commits into from
Jan 22, 2023
Merged

Add AprilTag support to Limelight #70

merged 6 commits into from
Jan 22, 2023

Conversation

vincentw921
Copy link
Contributor

Co-authored-by: Sam Belliveau sam.belliveau@gmail.com

vincentw921 and others added 4 commits January 12, 2023 22:07
Co-authored-by: Sam Belliveau <sam.belliveau@gmail.com>
Copy link
Collaborator

@Sam-Belliveau Sam-Belliveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@anivanchen anivanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get this tested with a Limelight.

@anivanchen
Copy link
Member

Also implement the other new NT entries and rename the PR to add apriltag support.

@vincentw921 vincentw921 changed the title Add Pose3d support to Limelight Add AprilTag support to Limelight Jan 13, 2023
@vincentw921 vincentw921 merged commit b1e7c83 into main Jan 22, 2023
@vincentw921 vincentw921 deleted the vw/Apriltag branch January 22, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants