Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite as an extension of CSS #96

Merged
merged 0 commits into from
Mar 16, 2024
Merged

rewrite as an extension of CSS #96

merged 0 commits into from
Mar 16, 2024

Conversation

braver
Copy link
Member

@braver braver commented Jul 18, 2022

I've effectively frozen the Sass syntax as it's a ton of work, much less popular, it's even missing features from the main SCSS syntax... and users seem to be reasonable happy with it I guess. This PR rewrites most of the SCSS syntax to build upon the CSS syntax whenever possible, and borrows heavily from the work done on the Less syntax.

The intent is not to merge but to set this as the new default branch for this repo (potentially under a different name), and to make releases of it available to versions of ST > 4171. And once approved to move the entire repo into the SublimeText org.

Confirmed fixes for all open issues:

@braver braver closed this Mar 25, 2023
@braver braver reopened this Mar 25, 2023
@braver
Copy link
Member Author

braver commented Feb 11, 2024

For anyone following this, "recent" work on the Less package has inspired a different approach. Currently re-writing tests to match the language documentation, and step-by-step reassembling and improving each language feature. It's going to take a while, but progress isn't disappointing actually.

@braver braver changed the title simplify matching sublimehq/Packages/pull/3354 rewrite as an extension of CSS Feb 11, 2024
Tests/syntax_test_css.scss Outdated Show resolved Hide resolved
@deathaxe
Copy link
Member

deathaxe commented Mar 5, 2024

Not yet complete, and various CSS tests pending, but took some steps forward.

Split functions and mixins and try to identify more details using scopes.

May require some adjustments to symbol list and index definitions (e.g.: mixins).

Syntaxes/SCSS.sublime-syntax Outdated Show resolved Hide resolved
Syntaxes/SCSS.sublime-syntax Outdated Show resolved Hide resolved
Syntaxes/SCSS.sublime-syntax Outdated Show resolved Hide resolved
@braver
Copy link
Member Author

braver commented Mar 15, 2024

@deathaxe Ok if I move this repo to the Sublime Text org? GitHub's redirects should prevent breakage, but I didn't want to move it when you're right in the middle of something.

@deathaxe
Copy link
Member

Yes, redirects should keep things going.

I barely can find obvious changes needed. I guess it would require some practical use and feedback to find remaining bugs.

So, feel free to move it.


If it comes to releasing...

would it make sense to freeze current master as st3 branch and squash merge commits of this PR into master?

As this PR requires CSS shipped with ST4169, I think of probably creating a ST4107 branch with that CSS bundled, to serve older releases as well with latest fixes.

@braver
Copy link
Member Author

braver commented Mar 16, 2024

I barely can find obvious changes needed. I guess it would require some practical use and feedback to find remaining bugs.

At some point, we just need real world feedback. I can do some cursory checks myself, and although I've basically used SCSS daily for about 10 years, and the language itself isn't even that huge, I doubt I use half the features.

would it make sense to freeze current master as st3 branch and squash merge commits of this PR into master?

The 3.0.1 tag can remain as the final release of the old master branch. We can keep serving that for ST < 4170. It's been stable for 2 years with only minor issues.

I would then delete the old master branch, and rename this simplify branch to master. That way we retain all history.

As this PR requires CSS shipped with ST4169, I think of probably creating a ST4107 branch with that CSS bundled, to serve older releases as well with latest fixes.

Sure, that's possible, go ahead. I personally wouldn't go to that effort. I haven't released updates for two years, people can wait a bit until ST4170+ becomes stable.

I'll move some stuff around and open a PR on package control to update the entry.

@braver
Copy link
Member Author

braver commented Mar 16, 2024

@deathaxe this is what happened:

  • the repo has been moved
  • there is a pull request in pc to handle that: Sass: v3 tags, prep for 4169+ wbond/package_control_channel#8891
  • the last tag has been re-tagged with the v3 prefix
  • the same pr for pc handles that, so that we can continue to tag new non-prefixed releases for ST > 4169
  • the old master branch has been renamed to old-master (and can eventually be deleted)
  • the simplify branch is renamed to master
  • all open issues resolved in this pr have been closed along with this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants