refactor(thread): Make spawnThreadTasks use a wait group & replace task params with TaskParams struct
#300
+101
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InKryption
force-pushed
the
ink/refactor-spawn-thread-tasks
branch
from
24217b1
to
e1c5a9c
Compare
Rexicon226
requested changes
Oct 7, 2024
0xNineteen
previously approved these changes
Oct 7, 2024
The function now takes only two arguments: the task function, and a config struct which is parameterized on the task function type info in order to also contain the parameter tuple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from some of my experimentation; doesn't appear to cause any measurable performance impact, reduces allocations (the total amount allocated will likely be similar since it's adding more metadata to the thread metadata), and overall seems to simplify and improve the code quality in my opinion.
Also resolves a TODO with a fairly simple solution.