[FEATURE] Fluid code in comments no longer interpreted #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2b
force-pushed
the
feature/commentRemoval
branch
4 times, most recently
from
1bcbc40
to
1276ec0
Compare
|
Resolves #894 |
s2b
force-pushed
the
feature/commentRemoval
branch
from
1276ec0
to
e3459ef
Compare
Previously, the behavior of the `<f:comment>` ViewHelper was confusing: Even if invalid Fluid code (e. g. syntax errors or a non-existent ViewHelper) was wrapped with `<f:comment>`, it would still be interpreted by the Fluid parser and an exception would be thrown. This patch resolves this similarly to CDATA handling. It introduces a new TemplateProcessor, which is executed before any other parsing and strips out the contents of Fluid comments. The `<f:comment>` ViewHelpers are kept intact and are filled with empty lines. This can be helpful when debugging Fluid templates because the line numbers in exceptions are consistent to the original template file. This new TemplateProcessor is then registered in the default RenderingContext implementation. For systems that set their own TemplateProcessors, this would probably need adjustments. However, this change is not breaking since the old functionality is still there. Fluid's own tests however now assume that this new TemplateProcessor is registered and are adjusted properly in this patch.
s2b
force-pushed
the
feature/commentRemoval
branch
from
e3459ef
to
6fed827
Compare
lolli42
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the behavior of the
<f:comment>ViewHelper was confusing:Even if invalid Fluid code (e. g. syntax errors or a non-existent ViewHelper)
was wrapped with
<f:comment>, it would still be interpreted by theFluid parser and an exception would be thrown.
This patch resolves this similarly to CDATA handling. It introduces a new
TemplateProcessor, which is executed before any other parsing and strips
out the contents of Fluid comments. The
<f:comment>ViewHelpers arekept intact and are filled with empty lines. This can be helpful when
debugging Fluid templates because the line numbers in exceptions are
consistent to the original template file.
This new TemplateProcessor is then registered in the default
RenderingContext implementation. For systems that set their own
TemplateProcessors, this would probably need adjustments. However,
this change is not breaking since the old functionality is still there.
Fluid's own tests however now assume that this new TemplateProcessor
is registered and are adjusted properly in this patch.