Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide trait implementation for supported JSON libraries #193

Merged
merged 160 commits into from
Jan 17, 2022
Merged

Provide trait implementation for supported JSON libraries #193

merged 160 commits into from
Jan 17, 2022

Conversation

prince-chrismc
Copy link
Collaborator

This is a huge PR. A few things got clumped together as I found and sorted out issues.
I am able to break this down if you prefer. Just let me know!

resolves #174

Breaking Changes

jwt::picojson_traits became jwt::traits::kazuho_picojson

All traits are within a namespace and follow the convention of author_project

Highlists

  • coverage for all JSON libraries
    • tests
    • examples
    • badging
    • refactored actions installing them
  • automatic code generation for tests and default traits
    • some exceptions apply
  • linting now checks all files
    • new actions + refactored workflows

Files to skip

  • tests/traits/** are all auto generated
  • examples/** auto generated or moved
  • jwt/traits/*/defaults.h auto generated

@prince-chrismc
quick poc for Thalhammer#174
083176b
@prince-chrismc
Copy paste
1d5c82a
@prince-chrismc
Rename include/jwt-cpp/traits/traits.h to include/jwt-cpp/traits/dani…
bdfea02 
…elaparker-jsoncons/traits.h
@prince-chrismc
Create traits.h
4687641
@prince-chrismc
adding a namespace
35a58c1
@prince-chrismc
mustache + action to automate defaults generation
7466ea1 
since they should always be the same
@prince-chrismc
fix order
77c4875
@prince-chrismc
traits tests should use traits
20f57fb
@prince-chrismc
playing with header order
6fda30d 
to make clang happy
@prince-chrismc
install all possible traits
1f2e504 
switch badge name to sha
@prince-chrismc
Update CMakeLists.txt
60a9e9d
@prince-chrismc
Update traits.h
89e8b07
@prince-chrismc
try commenting corrected code
a033ad9
@prince-chrismc
rm typescript
403eaf9
@prince-chrismc
make sure to implace edit
60f2507
@prince-chrismc
dont comment when no diff
7c0ee84
@prince-chrismc
apply linting
66fd868
@prince-chrismc
fixup boost-json traits
6057233
@prince-chrismc
move comment and render to composite action
9f242a9
@prince-chrismc
actions/github-script does not leave context in the usual spot
2ba21ad
@prince-chrismc
enabled globstar
7bd1c6d
@prince-chrismc
make sure to forward inputs
a0f6312
@prince-chrismc
try using env normally
c033efb
@prince-chrismc
fix typo
a0d0d75
@prince-chrismc
pass in linter name correctly
8bb061f
@prince-chrismc
debug print
6d432e7
@prince-chrismc
fix linting issues
a23b018
@prince-chrismc
more debug printing
e5aff5d
@prince-chrismc
fix linting issues
bb6c4da
@prince-chrismc
fix typpo + more rebug print
45c46a3
prince-chrismc and others added 27 commits December 1, 2021 22:34
@prince-chrismc
Update lint.yml
a6f9efc
@prince-chrismc @kleinmrk
sync (#16)
e00645f 
* 🔧 Replace RSA related deprecated functions (Thalhammer#189)

* RSA_size() --> EVP_PKEY_size()

* getting rid of deprecated functions in rsa-pss signature creation

* getting rid of deprecated functions in rsa-pss signature verification

* generate_hash not used in pss

* Update lint.yml

* Update lint.yml

* Update lint.yml

Co-authored-by: Marek Klein <kleinmrk@gmail.com>
@prince-chrismc
Update lint.yml
2447cbc
@prince-chrismc
Merge branch 'master' into provide-traits
2e0699f
@prince-chrismc
make sure to use install nlohmann-json
9807bb2
@prince-chrismc
make action folder match trait names
0f80f6d
@prince-chrismc
add example + badge for kazuho-picojson
7e521e0
@prince-chrismc
link to new examples
875866b
@prince-chrismc
revert debug code
3ae2a23
@prince-chrismc
Merge branch 'Thalhammer:master' into provide-traits
7580b0c
@prince-chrismc
dont mix matrix with uses
ec6aaf4
@prince-chrismc
fix bad copy paste
ec88e81
@prince-chrismc
spec interface library so it's no compiled
5177d41
@prince-chrismc
fix installer
e804f2a
@prince-chrismc
fix to interface
f226867
@prince-chrismc
fix example
df2849b
@prince-chrismc
attempt 2
5b94af3
@prince-chrismc
make sure to avoid circular reference
b8c2f85
@prince-chrismc
attempt 3
f7ce6ff
@prince-chrismc
Merge pull request #14 from prince-chrismc/provide-traits
a198367 
Provide traits
@prince-chrismc
white space
b4d8e00
@prince-chrismc
white space
bff185d
@prince-chrismc
Update and rename .github/actions/comment-linting/action.yml to .gith…
e1ae42c 
…ub/actions/process-linting-results/action.yml
@prince-chrismc
Update lint.yml
bde2011
@prince-chrismc
Update action.yml
d1eca2f
@prince-chrismc
Update action.yml
e748608
@prince-chrismc
Update README.md
2adbbc3
@prince-chrismc prince-chrismc changed the title Provide trait implementation for support JSON libraries Provide trait implementation for supported JSON libraries Jan 17, 2022
@prince-chrismc prince-chrismc merged commit 5c9787e into Thalhammer:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thalhammer Thalhammer Awaiting requested review from Thalhammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Provide more supported traits
1 participant
@prince-chrismc