Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions(Visually & into API) #26

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

ItsTheBdoge
Copy link
Contributor

2019-10-13_16 53 46
Adds prefix to identifier

Added:
Command to set specified slot identifiers size
API method to set size

(get size is in v1.0.3 but added it in to get it to work)

added set slot size command, set slot size API, and added prefix to tooltip curios item id
@Aizistral
Copy link
Contributor

I'd like to say, this prefix instills doubt in me. Especially colors.

@TheIllusiveC4 TheIllusiveC4 self-assigned this Oct 14, 2019
@TheIllusiveC4 TheIllusiveC4 added the type: enhancement New feature or request label Oct 14, 2019
@TheIllusiveC4
Copy link
Owner

@Extegral Could you elaborate on your thoughts? What is the cause for skepticism?

@Aizistral
Copy link
Contributor

On a second thought, wording is actually fine. However, it may be my personal opinion, but orange color for "Slot:" and light gray for slot type don't seem to look so good.

I would have offered something like orange and yellow, or maybe orange and light purple.

@ItsTheBdoge
Copy link
Contributor Author

ItsTheBdoge commented Oct 14, 2019

image
Thats with orange and yellow

@TheIllusiveC4 TheIllusiveC4 merged commit 32da5f5 into TheIllusiveC4:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants