Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cname dissection to ndpi dns #7

Merged
merged 7 commits into from
Oct 25, 2022
Merged

add cname dissection to ndpi dns #7

merged 7 commits into from
Oct 25, 2022

Conversation

hl33ta
Copy link

@hl33ta hl33ta commented Oct 24, 2022

No description provided.

@hl33ta hl33ta requested a review from shla2022 October 24, 2022 20:33
shla2022
shla2022 reviewed Oct 25, 2022
View reviewed changes
src/lib/protocols/dns.c Outdated Show resolved Hide resolved
@shla2022
Copy link

Minor comment relating to style.

shla2022
shla2022 approved these changes Oct 25, 2022
View reviewed changes
Copy link

@shla2022 shla2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ I suggest squashing on merge to reduce multiple commits here.
Uses existing code and appears compliant with expected interface. LGTM.

@spendletonliveaction spendletonliveaction merged commit 7ac5837 into threateye-4.2 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spendletonliveaction spendletonliveaction spendletonliveaction left review comments

@shla2022 shla2022 shla2022 approved these changes

Assignees

@spendletonliveaction spendletonliveaction

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hl33ta @shla2022 @spendletonliveaction