-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing node bindings in NodeNorm /query output #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that localhost entry in the openapi going to make it into the version hosted at the smartapi registry?
NameRes uses the same Bad news: the localhost entries do get picked up by SmartAPI via Yaphet's trapi-openapi app: https://trapi-openapi.apps.renci.org/utility/infores%3Asri-name-resolver?version=%2A Good news: those I'm going to ask @YaphetKG to review this PR as well in case there's a better way to do what I'm trying to do here. |
I should have added in my previous comment that I've deployed this to https://nodenormalization-dev.apps.renci.org/docs and that does correctly transform localhost to the URL (i.e. https://nodenormalization-dev.apps.renci.org/1.4). So that localhost entry should be fine. |
As reported in #229. As far as I can tell, this was caused by merged_binding being None, which could cause it to end up being an object later in the code. Handling the case where it's None appears to fix this problem as per the simple test in PR TranslatorSRI/babel-validation#26.
Fixes #229.