Release #14
Release #14
Conversation
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
| maintenance = { status = "actively-developed" } | ||
|
|
||
| [package.metadata.docs.rs] | ||
| default-target = "x86_64-pc-windows-msvc" |
There was a problem hiding this comment.
Don't think this is needed, all of the vdb code is (hopefully?? side-eye to ebac9b3) platform independent?
There was a problem hiding this comment.
I don't see why this create wouldn't be compatible with Linux. On the other hand, I also don't see a situation where it would compile on one platform but not the other.
There was a problem hiding this comment.
There's nothing API-specific about this crate either, so I'd leave the default at whatever docs.rs sets it to by removing these two lines, rather than leaving it in and implying there's something special about the MSVC target.
There was a problem hiding this comment.
https://github.com/Traverse-Research/vdb-rs/actions/runs/4534288762/jobs/7988270274?pr=15 shows: bevy hoists in a ton of irrelevant dependencies (fortunately, only in the example 😌) and those are not installed on the Linux CI by default. Perhaps those could be disabled by default to have a positive impact on compile-times, too.
There was a problem hiding this comment.
I don't know what bevy exposes in terms of features to disable this but the linux CI was failing on not having alsa at least.
There was a problem hiding this comment.
Yup, pushed that to #13 to get rid of it and speed things up, we only need PBR support 🎉!
|
|
||
| [package.metadata.docs.rs] | ||
| default-target = "x86_64-pc-windows-msvc" |
There was a problem hiding this comment.
| [package.metadata.docs.rs] | |
| default-target = "x86_64-pc-windows-msvc" |
No description provided.