📖 Add VdbReader struct with read_grid() functionality to allow users to specify which grid to load
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilioLaiso
changed the title
VdbReader struct with read_grid() functionality to allow users to specify which grid to load from the available ones VdbReader struct with read_grid() functionality to allow users to specify which grid to load
…ve header, while exposing a `read_grid(name)` API to load specific grids
EmilioLaiso
force-pushed
the
separate-vdb-reader-from-grid-parsing
branch
from
66ce223
to
afa0a29
Compare
Jasper-Bekkers
approved these changes
Jul 11, 2023
|
|
||
| let grid = read_vdb::<_, half::f16>(&mut reader).unwrap(); | ||
| let mut vdb_reader = VdbReader::new(BufReader::new(f)).unwrap(); | ||
| let grid = vdb_reader.read_grid::<half::f16>("density").unwrap(); |
https://github.com/Traverse-Research/vdb-rs/pull/41/files?diff=unified&w=1 (Which enables "ignore whitespace") so that all reindented code isn't counted as "changed" :) |
MarijnS95
reviewed
Jul 11, 2023
MarijnS95
reviewed
Jul 11, 2023
MarijnS95
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Looks simple on the surface, not sure if we should more cautiously document that read_grid loosely uses name (how about just using ==, and adding an accessor function that returns the names of all the grids available?).
Feels like some helper functions don't need to become associated functions, even if it simplifies some repetitive generics and trait bounds.
…necessity to `find()` on a vector. Also expose function to retrieve all the available descriptor names.
MarijnS95
reviewed
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
read_vdbfunction in favor of the new approach of having the user create aVdbReaderclass, which takes ownership over a reader and parses theArchiveHeaderand the vector ofGridDescriptors.The
VdbReaderthen exposes aread_gridfunction on which the user can specify the type of the grid data and the name of the grid being requested.