Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application form save data bug fix #285

Open
wants to merge 3 commits into
base: 2024-root
Choose a base branch
from

Conversation

Luceium
Copy link

@Luceium Luceium commented Nov 7, 2023

I discovered a bug on the application portal where when I tried to save my progress I had an infinite loading status.
The network tab revealed that there was a 401 status code. So if a users auth expires before they try saving they can't save and infinitely see a loading screen.

The saveData() function in src/store/form/actions.ts was the only api call without a .catch() statement. I added the catch statement in the same style as the rest of the file. Then I removed redundant calls to dispatch(loadingEnd()) by moving it too a .final() statement.

Note:
I don't have a .env file so my changes are untested. It would be great to see an example .env file listed in the README so contributors can test code. I checked the wiki and used find . env | grep env but I didn't find any env related files. Maybe I missed it.

Happy hacking!

@danknessdra
Copy link

+1

@Luceium Luceium changed the base branch from 2022-root to 2024-root November 15, 2023 03:19
@Luceium
Copy link
Author

Luceium commented Nov 15, 2023

Changed target branch to most recent and active branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants