Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline styles were added. #484

Merged
merged 5 commits into from
May 23, 2024
Merged

Underline styles were added. #484

merged 5 commits into from
May 23, 2024

Conversation

Ramin-Farhadi
Copy link
Contributor

Description
Added two new underline classes for yellow backgrounds and white backgrounds.

Motivation and Context
Found out that this heavy-underline background is something that we are using regularly. I thought that's a good idea to have that as a class in order to prevent using custom style sheet every time.

How Has This Been Tested?
local

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires an update to the documentation.
  • I have updated the documentation accordingly.

@Ramin-Farhadi Ramin-Farhadi self-assigned this May 22, 2024
@Ramin-Farhadi Ramin-Farhadi requested a review from a team as a code owner May 22, 2024 21:23
@Ramin-Farhadi Ramin-Farhadi requested review from jmbarne3 and kimberspencer and removed request for a team May 22, 2024 21:23
Copy link

@kimberspencer kimberspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update classes to match what is in Athena, i.e. heavy-underline-secondary (https://ucf.github.io/Athena-Framework/utilities/colors/)

@Ramin-Farhadi Ramin-Farhadi merged commit 351b340 into rc-v3.23.3 May 23, 2024
@Ramin-Farhadi Ramin-Farhadi deleted the underline-style branch July 30, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants