-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E3SM UXarray and Dask Examples #836
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB philipc2 commented on 2024-07-26T17:50:07Z Line #2. # Parallel load Try to avoid standard comments in these notebooks and include these either as markdown or headings. |
View / edit / reply to this conversation on ReviewNB philipc2 commented on 2024-07-26T17:50:08Z Make sure to emphasize that the data is lazy-loaded. If you index a data variable (i.e. soa_c1DDF), show that you don't actually see the data.
I would add another block, such as the following
to show how to get the data in me memory (can also show the .values) too |
View / edit / reply to this conversation on ReviewNB philipc2 commented on 2024-07-26T17:50:08Z Add a small markdown comment above to make sure to close your dask client, stating that it cleanly closes all dask workers and the scheduler |
The Gallery can house both Workflow & Visualization examples. Do you think this sepperation is appropriate? The equations look like this for me in the rendered docs in light mode. Looks like they are broken with the Dark Mode. Have you ever encountered this @anissa111 ? |
View / edit / reply to this conversation on ReviewNB rajeeja commented on 2024-08-12T19:13:53Z A little mention of what all can go as Explain what is ".Q" and why this results in Dask graph "18 chunks in 2 graph layers", the more details on how to choose chunk size and info around what happens when you choose the better. |
View / edit / reply to this conversation on ReviewNB rajeeja commented on 2024-08-12T19:13:53Z the only change to A lot happens under the hood that needs explaining. In this case you create a
https://docs.xarray.dev/en/stable/user-guide/dask.html (specifically see the mention of dask.delayed) |
I haven't actually. I poked around for a bit and suggest starting at this stackoverflow post and here in mathjax documentation. Let me know what you find! |
I think of "gallery" as just being images/viz. |
I've tried to closely follow what Xarray does with their gallery. , which is a combination of visualization and workflow examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments in e3sm-load notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the long gap in reviews! I've left a few suggestions here. Once we've resolved all the ReviewNB comments, we should be good to go!
workflow-examples: | ||
- title: Working with MPAS Grids | ||
path: examples/working-with-mpas-grids.ipynb | ||
thumbnail: _static/thumbnails/004-thumbnail.png | ||
|
||
- title: Calculations on E3SMv2 Output with UXarray |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An idea for a more descriptive title, any thoughts?
- title: Calculations on E3SMv2 Output with UXarray | |
- title: Radiative Feedback Analysis on E3SMv2 Model Output |
Now updated with link. View entire conversation on ReviewNB |
Updated View entire conversation on ReviewNB |
Related to bug in View entire conversation on ReviewNB |
Co-authored-by: Philip Chmielowiec <67855069+philipc2@users.noreply.github.com>
Co-authored-by: Philip Chmielowiec <67855069+philipc2@users.noreply.github.com>
Closes #822
Overview
Added user guide notebook on parallel loading with Dask; and workflow examples with E3SM output with visualization and calculations.
PR Checklist
General
Examples
docs/examples/
folderdocs/examples.rst
toctreedocs/gallery.yml
with appropriate thumbnail photo indocs/_static/thumbnails/