CURA-11634 Show any color in color submenu for machines that support it #19688
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wawanbreton
approved these changes
Sep 30, 2024
…dded. Previously, this was only checked on 'load all' leading to some weird edge-ish cases where loading an any-color material on a printer that does support it, briefly also made it available on printers that (otherwise would, but) don't -- but only for that session. part of CURA-12159 (also refer to CURA-11634)
wawanbreton
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Abstract color profiles are filtered out of the color options sub menu. This pull request will only filter these profiles out for machines that do not supports_abstract_colors (default = false). S5 and S7 line and factor 4 machines support abstract color profiles and will therefore be shown.
Note: this requires FW version >=10.1 for the Factor 4 en version >=9 for the S-line [in the V&V release process at the moment]
Type of change
How Has This Been Tested?
Tested that the Any Color profiles show up for S5, S7 and factor 4, but nor for the S3.
Test Configuration:
Checklist:
CURA-12159