Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-520 sketch & sketch large updates #19701

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

alanbjorklund
Copy link
Contributor

PP-520

minor updates to sketch & sketch large
mark these printers public
ran 20 prints in the NYC office to validate the print quality

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

alanbjorklund and others added 2 commits September 30, 2024 22:43
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_sketch.def.json Outdated Show resolved Hide resolved
@github-actions github-actions bot dismissed stale reviews from themself October 1, 2024 02:45

No Clang-Tidy warnings found so I assume my comments were addressed

Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mesh files are missing, and some setting definitions issues pointed out by unit tests

resources/definitions/ultimaker_sketch.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_sketch.def.json Outdated Show resolved Hide resolved
@alanbjorklund alanbjorklund merged commit a426f05 into main Oct 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants