Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create biobambam markduplicates 2 cram step #20

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mp15
Copy link
Contributor

@mp15 mp15 commented Apr 1, 2015

Create biobambam markduplicates 2 cram step. I need to test this yet but I thought I'd throw it open for review.

}

method description {
return "Marks duplicates in BAM files";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marks duplicates in CRAM files using biobambam

@mcshane
Copy link
Member

mcshane commented Apr 1, 2015

Thanks Martin. Have left some comments. The file is named biobambam_mark_duplicates_bbtwo.pm instead of biobambam_mark_duplicates_two.pm for some reason?

Can you add a one step test like those in t/VRPipe/Steps/ as I know this is not going to run as-is because of a few typos. Otherwise looks good.

@mp15 mp15 force-pushed the bbmkdup2 branch 3 times, most recently from e0af7f5 to 3ca4176 Compare April 13, 2015 10:59
Signed-off-by: Martin O. Pollard <mp15@sanger.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants