-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search box UI issues after geocoding #561
Comments
btw, could have option after autocompleting the inputbox from reverse geocoding to do an automatic forward search to suggest other similar addresses. But I'd prefer the default to be to not do it. That is to just complete the inputbox with the found address to edit it and show the search history at the dropdown. User can then just press enter to search for that address |
I'll try to see what can be done... |
btw, it would also be nice to have an option to have the searchbox open from the start (apart from the one that would control whether it autocloses). Don't remember if it had such |
Hello |
Is this released? btw, I noticed that 3.17 says 3.16 in its comments, 3.16 says 3.15 and so one, but 3.12 says 3.12 ok in its header whereas 3.13 also says 3.12. Not sure if it is that they grab the wrong versions or that you had forgotten to change the version in the header in some releases (assuming that is not an autogenerated thing from jsdelivr.net) |
Tried it at the examples page with Nominatim and seems to work fine |
Not yet released. I'll try to publish asap... |
3.1.18 is on the rails. |
yep, |
There are some UI issues with Search box control and reverse geocoding. Trying with SearchNominatim.
After reverse geocoding search, if one picks a location the searchbox control closes and they don't get to see the title of the location they have picked till they open search box again to see it as top entry in history. Should have an AutocloseAfterReverseGeocoding defaulting to false I think. An AutocloseAfterGeocoding defaulting to true would also be useful
If they had searched for some address before, then the searchbox will show those results everytime they reopen the searchbox, even if they had done reverse geocoding search (see steps described for issue 1). I believe reverse geocoding search should clear the search box. There seems to be a commented out "this.setInput('', true);" at SearchNominatime line 112:
ol-ext/src/control/SearchNominatim.js
Line 112 in 4244a49
not sure if it should be done before this._handleSelect(resp, true); though - ideally the reverse result should also show in the input, not just in the history so that you can edit/finetune the address and search forward this time
The text was updated successfully, but these errors were encountered: