Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dotnet module failure on Windows #1902

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

metthal
Copy link
Contributor

@metthal metthal commented Mar 29, 2023

create_full_name() used strdup() even on Windows where all str* functions are masked behind yr_str*() functions which internally used HeapAlloc()/HeapFree() which does not cooperate well with malloc()/free().

Thanks to @wxsBSD & @tlansec for finding the bug.

@google-cla
Copy link

google-cla bot commented Mar 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@metthal metthal changed the title Fixed dotnet module failed on Windows Fixed dotnet module failure on Windows Mar 29, 2023
create_full_name() used strdup() even on Windows where all str*
functions are masked behind yr_str*() functions which internally used
HeapAlloc()/HeapFree() which does not cooperate well with
malloc()/free().
@plusvic plusvic merged commit cdb0253 into VirusTotal:master Mar 29, 2023
plusvic pushed a commit that referenced this pull request Mar 29, 2023
create_full_name() used strdup() even on Windows where all str*
functions are masked behind yr_str*() functions which internally used
HeapAlloc()/HeapFree() which does not cooperate well with
malloc()/free().
@plusvic plusvic mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants