Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge refactoring #16

Merged
merged 13 commits into from
Mar 1, 2021
Merged

Huge refactoring #16

merged 13 commits into from
Mar 1, 2021

Conversation

imDaniX
Copy link
Contributor

@imDaniX imDaniX commented Feb 28, 2021

I decided to refactor a whole project.

  1. Made it more consistent with java naming guidelines.
  2. Removed unnecessary static utility classes.
  3. Used private modifier where possible.
  4. Moved classes to more logical places/packages.

Also some tweaks here and there. All of that was done for easier plugin maintaining in the future. You also forgot to specify dynmap api scope - that was the reason why jar file was so huge.

@WiIIiam278 WiIIiam278 self-assigned this Mar 1, 2021
@WiIIiam278
Copy link
Owner

Thank you for this! It's a big improvement all around, fixes my lazy code.
Only issue I noticed was that you forgot to register setwarp and sethome, but I will merge this and correct that.
Data manager will probably want further refactoring down the road to allow database work to be done async as per #1, but this will really help with doing that a little down the road.

@WiIIiam278 WiIIiam278 merged commit b6301ab into WiIIiam278:master Mar 1, 2021
@imDaniX imDaniX deleted the refactor/style branch March 1, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants