General Feature Additions #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws all homes not just private homes
WiIIiam278
requested changes
Feb 24, 2024
bukkit/src/main/java/net/william278/huskhomes/user/BukkitUser.java
Outdated
Show resolved
Hide resolved
| @@ -110,6 +112,8 @@ private Optional<PaginatedList> generateList(@NotNull CommandUser executor, @Not | |||
| plugin.getLocales() | |||
| .getRawLocale("home_list_item", | |||
| Locales.escapeText(home.getName()), home.getSafeIdentifier(), | |||
| home.isPublic() ? plugin.getLocales().getRawLocale("home_is_public").orElse("�fb9a&Public"): | |||
There was a problem hiding this comment.
Let's just supply Public or Private if no locale is found here without formatting :)
common/src/main/java/net/william278/huskhomes/user/OnlineUser.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Feb 24, 2024
…here it would not remove invulnerability from player on sponge
|
Done all changes |
WiIIiam278
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Add configurable invulnerability period after teleporting
Implements Show home privacy status in /homelist