Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images fail to load when building Gutenberg using Xcode 12 #25431

Closed
guarani opened this issue Sep 18, 2020 · 1 comment · Fixed by #25470
Closed

Images fail to load when building Gutenberg using Xcode 12 #25431

guarani opened this issue Sep 18, 2020 · 1 comment · Fixed by #25470
Assignees
@guarani
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@guarani
Copy link
Contributor

guarani commented Sep 18, 2020 •
edited
Loading

Describe the bug

When building the demo app on Xcode 12, images can no longer be added to the Image block.
It looks to affect any block that supports images (videos appear unaffected).

To reproduce
Steps to reproduce the behavior:

  1. Using Xcode 12, build and run the app
  2. Add an Image block
  3. Add an image to that block (its irrelevant whether or not the app has permission to just some or all photos)
  4. Notice the image appears to load (loading bar advances) but the image fails to appear in the block

Expected behavior
Building the demo app on Xcode 12 shouldn't cause images to fail to load.

Screenshots

Smartphone (please complete the following information):

  • Device: iPhone 11
  • OS: iOS 14
  • Demo App Version 3ed0910
@guarani guarani added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Sep 18, 2020
@guarani guarani mentioned this issue Sep 18, 2020
Merged
3 tasks
@guarani
Copy link
Contributor Author

guarani commented Sep 18, 2020 •
edited
Loading

There is a known bug in Xcode 12 that accounts for what we see here. It was fixed here but appears to be in RN 0.63, and we're still on RN 0.61.5.

The option I'm going to go with is a patch (see facebook/react-native#29279 (comment)).

guarani added a commit that referenced this issue Sep 18, 2020
@guarani
Fix image block render in Xcode 12
b5bc7fd 
This PR fixes #25431 which is a bug that prevents Image blocks from rendering their images. This only affects builds made using Xcode 12.
The bug itself is in React Native itself and was fixed in RN 0.63. Since we're on RN 0.61.5, we need to apply a patch (as suggested here facebook/react-native#29279 (comment)).

The patch was applied using the following steps found here: facebook/react-native#29279 (comment)
@guarani guarani mentioned this issue Sep 18, 2020
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 18, 2020
guarani added a commit that referenced this issue Sep 28, 2020
@guarani
Fix image block render in Xcode 12 (#25470)
ed848a0 
* Fix image block render in Xcode 12

This PR fixes #25431 which is a bug that prevents Image blocks from rendering their images. This only affects builds made using Xcode 12.
The bug itself is in React Native itself and was fixed in RN 0.63. Since we're on RN 0.61.5, we need to apply a patch (as suggested here facebook/react-native#29279 (comment)).

The patch was applied using the following steps found here: facebook/react-native#29279 (comment)

* Remove unnecessary changes to RN patch file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guarani guarani

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix image block render in Xcode 12 WordPress/gutenberg
1 participant
@guarani