Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flume dependency optional and cleanup features #73

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented Aug 14, 2024

  • Rename use-ignore feature by ignore to conform with macros crate. Let me know if the name use-ignore is preffered.
  • Change ignore implicit feature name by dep:ignore. Note that dep: syntax is available starting from Rust v1.60 and MSRV for fluent-templates is v1.70.
  • Make flume and log dependencies optional by refactoring file walkers. The dependency flume only is needed when using ignore.
  • Add walkdir feature.

@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit f834a6f into XAMPPRocky:master Aug 15, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Aug 15, 2024
@mondeja mondeja deleted the optional-flume branch August 15, 2024 14:09
@github-actions github-actions bot mentioned this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants