Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade pylint and remove pylint CI workflow #107

Merged
merged 5 commits into from
Jul 22, 2022

Conversation

bestquark
Copy link
Collaborator

@bestquark bestquark commented Jul 21, 2022

Context for changes

Downgradepylint to v2.13.5 to allow the use of the no-self-use flag in unit tests and remove pylint CI workflow as this is covered by code-factor.

  • New features:
    • N/A
  • Bug fixes:
    • Fix incompatibility between code-factor and pylint CI check
  • Improvements:
    • N/A
  • Documentation changes:
    • N/A

Example usage and tests

  • Not Applicable

Performance results justifying changes

  • Not Applicable

Workflow actions and tests

  • Not Applicable

Expected benefits and drawbacks

Expected benefits:

  • Remove duplicated pylint check.

Possible drawbacks:

  • If we stop using Codefactor we need to reintroduce pylint action to the CI workflow.

Related Github issues

  • Not Applicable

Checklist and integration statements

  • My Python and C++ codes follow this project's coding and commenting styles as indicated by existing files. Precisely, the changes conform to given black, docformatter and pylint configurations.
  • I have performed a self-review of these changes, checked my code (including for codefactor compliance), and corrected misspellings to the best of my capacity. I have synced this branch with others as required.
  • I have added context for corresponding changes in documentation and README.md as needed.
  • I have added new workflow CI tests for corresponding changes, ensuring codecoverage is 95% or better, and these pass locally for me.
  • I have updated CHANGELOG.md following the template. I recognize that the developers may revisit CHANGELOG.md and the versioning, and create a Special Release including my changes.

@bestquark bestquark marked this pull request as ready for review July 21, 2022 21:04
@bestquark bestquark self-assigned this Jul 21, 2022
@bestquark bestquark added bug Something isn't working chores Standard routines for open-source software projects labels Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (763e107) to head (d5ae8df).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          36       36           
  Lines        2209     2209           
=======================================
  Hits         2125     2125           
  Misses         84       84           
Files Coverage Δ
flamingpy/_version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763e107...d5ae8df. Read the comment docs.

Copy link
Contributor

@sduquemesa sduquemesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bestquark for saving devs from some headaches! 😎

.github/CHANGELOG.md Outdated Show resolved Hide resolved
bestquark and others added 3 commits July 22, 2022 10:36
Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com>
@ilan-tz ilan-tz merged commit 4b73a62 into XanaduAI:main Jul 22, 2022
@bestquark bestquark deleted the pylint-downgrade branch July 22, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chores Standard routines for open-source software projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants