Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Deletion of remaining Cython lines #122

Merged
merged 6 commits into from
Aug 31, 2022
Merged

[Hotfix] Deletion of remaining Cython lines #122

merged 6 commits into from
Aug 31, 2022

Conversation

nariman87
Copy link
Contributor

Context for changes

In #119, we have removed our Cython example and instructions. However, I have missed removing Cython tests in parts of the code, specifically main __init__.py. These are now all removed in this PR.

  • Improvements:
    • Our Cython example and instructions were removed on [Frozen Period] Special Release, August 2022 #119, however, there were some leftover Cython tests in parts of the code including main __init__.py. These unnecessary Cython lines are now fully removed.

Example usage and tests

  • Not Applicable

Performance results justifying changes

  • Not Applicable

Workflow actions and tests

  • Not Applicable

Expected benefits and drawbacks

Expected benefits:

  • All unnecessary Cythin lines were removed.

Related Github issues

Relates to #119.

Checklist and integration statements

  • My Python and C++ codes follow this project's coding and commenting styles as indicated by existing files. Precisely, the changes conform to given black, docformatter and pylint configurations.
  • I have performed a self-review of these changes, checked my code (including for codefactor compliance), and corrected misspellings to the best of my capacity. I have synced this branch with others as required.
  • I have added context for corresponding changes in documentation and README.md as needed.
  • I have added new workflow CI tests for corresponding changes, ensuring codecoverage is 95% or better, and these pass locally for me.
  • I have updated CHANGELOG.md following the template. I recognize that the developers may revisit CHANGELOG.md and the versioning, and create a Special Release including my changes.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #122 (ead00b3) into main (88b7d17) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   96.00%   96.03%   +0.03%     
==========================================
  Files          37       37              
  Lines        2425     2423       -2     
==========================================
- Hits         2328     2327       -1     
+ Misses         97       96       -1     
Impacted Files Coverage Δ
flamingpy/__init__.py 100.00% <ø> (+3.12%) ⬆️
flamingpy/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b7d17...ead00b3. Read the comment docs.

@nariman87 nariman87 self-assigned this Aug 31, 2022
@nariman87 nariman87 added the chores Standard routines for open-source software projects label Aug 31, 2022
@ilan-tz ilan-tz merged commit 191241d into main Aug 31, 2022
@ilan-tz ilan-tz deleted the cython-deletions branch August 31, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chores Standard routines for open-source software projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants