Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bron kerbosch #467

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Bron kerbosch #467

merged 4 commits into from
Oct 7, 2024

Conversation

danrr02
Copy link
Contributor

@danrr02 danrr02 commented Oct 1, 2024

#381 - Introduce Bron-Kerbosch Algorithm

  • Current implementation is of the basic algorithm without pivots but I would be happy to update to using pivots if requested.

Copy link
Owner

@ZigRazor ZigRazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD JOB!

@ZigRazor ZigRazor linked an issue Oct 2, 2024 that may be closed by this pull request
@ZigRazor ZigRazor added the enhancement New feature or request label Oct 2, 2024
@ZigRazor ZigRazor added this to the Algorithm Implementation milestone Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (564a8c0) to head (0521f2b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   97.87%   97.92%   +0.04%     
==========================================
  Files          87       89       +2     
  Lines       10079    10220     +141     
  Branches      670      671       +1     
==========================================
+ Hits         9865    10008     +143     
+ Misses        214      212       -2     
Flag Coverage Δ
unittests 97.92% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZigRazor
Copy link
Owner

ZigRazor commented Oct 3, 2024

@danrr02 the test build fails, can you correct it?

@danrr02
Copy link
Contributor Author

danrr02 commented Oct 5, 2024

@danrr02 the test build fails, can you correct it?

Hi, @ZigRazor

I have some questions about which builds you would like me to correct, and how I might go about doing that:

  1. The build which fails in CodeQL is failing due to an error in examples/NetworkDynamicsExample/network_dynamics_example.cpp:

error: invalid initialization of reference of type ‘const std::vector&’ from expression of type ‘const unsigned int’
29 | const std::vector& degrees = nodePair.second;

If this is the build which you referred to in your comment how would you like me to proceed? I have not interacted with this file at all so I do not want to prematurely attempt to resolve the error without being specifically requested to do so.

  1. The build which fails in CMake/build (windows-latest) will be difficult for me to resolve as I do not have access to a windows machine. If there is another way I can attempt to correct this I would appreciate any advice.

  2. I am also struggling to resolve the ctest failures in CMake/build(ubuntu-latest) and CMake/build(macos-latest) as I do not see the errors when running ctest in my local build/test directory.

Sorry for asking so many questions, but I just want to make sure everything is done properly.

Thanks,
danrr02

@ZigRazor
Copy link
Owner

ZigRazor commented Oct 7, 2024

@danrr02 sorry was a problem with the new version of Ctest, I correct the workflow.
We can merge it!

@ZigRazor ZigRazor merged commit 6284c8b into ZigRazor:master Oct 7, 2024
26 of 33 checks passed
@danrr02 danrr02 deleted the bronKerbosch branch October 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Bron-Kerbosch Algorithm
2 participants